| From: | Dave Cramer <davecramer(at)gmail(dot)com> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Binary support for pgoutput plugin |
| Date: | 2020-07-02 16:41:14 |
| Message-ID: | CADK3HH+CdvYpEL2SNw94186-LLEzBbAjpEjx==QP3dbLtNQQyw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
rebased
Thanks,
Dave Cramer
On Wed, 1 Jul 2020 at 06:43, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
> Honestly I'm getting a little weary of fixing this up only to have the
> patch not get reviewed.
>
> Apparently it has no value so unless someone is willing to review it and
> get it committed I'm just going to let it go.
>
> Thanks,
>
> Dave Cramer
>
>
> On Wed, 1 Jul 2020 at 04:53, Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
>> > On 7 Apr 2020, at 21:45, Dave Cramer <davecramer(at)gmail(dot)com> wrote:
>>
>> > New patch that fixes a number of errors in the check for validity as
>> well as reduces the memory usage by
>> > dynamically allocating the data changed as well as collapsing the
>> changed and binary arrays into a format array.
>>
>> The 0001 patch fails to apply, and possibly other in the series. Please
>> submit
>> a rebased version. Marking the CF entry as Waiting for Author in the
>> meantime.
>>
>> cheers ./daniel
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-First-pass-at-working-code-without-subscription-opti.patch | application/octet-stream | 21.9 KB |
| 0005-Remove-C99-declaration-and-code.patch | application/octet-stream | 1.3 KB |
| 0002-add-binary-column-to-pg_subscription.patch | application/octet-stream | 8.6 KB |
| 0004-get-relid-inside-of-logical_read_insert.patch | application/octet-stream | 2.5 KB |
| 0003-document-new-binary-option-for-CREATE-SUBSCRIPTION.patch | application/octet-stream | 2.8 KB |
| 0006-make-sure-the-subcription-is-marked-as-binary.patch | application/octet-stream | 828 bytes |
| 0007-check-that-the-subscriber-is-compatible-with-the-pub.patch | application/octet-stream | 7.6 KB |
| 0008-Changed-binary-and-changed-to-format-and-use-existin.patch | application/octet-stream | 16.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-07-02 16:41:22 | Re: Sync vs Flush |
| Previous Message | Dave Cramer | 2020-07-02 16:37:29 | why do we allow people to create a publication before setting wal_leve |