Re: proposal: possibility to read dumped table's name from file

From: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: proposal: possibility to read dumped table's name from file
Date: 2020-07-05 20:37:00
Message-ID: CAFj8pRCCJ1vqDREwK41tbRX8k96VSAWFe9uOCCAmLJ8cwJC4Vw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

ne 5. 7. 2020 v 22:31 odesílatel Justin Pryzby <pryzby(at)telsasoft(dot)com>
napsal:

> On Wed, Jul 01, 2020 at 04:24:52PM -0500, Justin Pryzby wrote:
> > On Thu, Jun 11, 2020 at 09:36:18AM +0200, Pavel Stehule wrote:
> > > st 10. 6. 2020 v 0:30 odesílatel Justin Pryzby <pryzby(at)telsasoft(dot)com>
> napsal:
> > > > > + /* ignore empty rows
> */
> > > > > + if (*line != '\0')
> > > >
> > > > Maybe: if line=='\0': continue
> > > > We should also support comments.
> >
> > Comment support is still missing but easily added :)
>
> Still missing from the latest patch.
>

I can implement a comment support. But I am not sure about the format. The
start can be "--" or classic #.

but "--" can be in this context messy

> With some added documentation, I think this can be RfC.
>
> --
> Justin
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2020-07-05 20:40:16 Re: Binary support for pgoutput plugin
Previous Message Daniel Gustafsson 2020-07-05 20:32:08 Re: [Patch] Invalid permission check in pg_stats for functional indexes