Re: ECPG cleanup and fix for clang compile-time problem

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, John Naylor <johncnaylorls(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: ECPG cleanup and fix for clang compile-time problem
Date: 2024-08-15 07:20:13
Message-ID: 9dbc7e00-e4ab-4284-9954-12f039f2bdeb@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15.08.24 02:43, Tom Lane wrote:
> I wrote:
>> Here's a rebased but otherwise identical patchset. I also added
>> an 0007 that removes check_rules.pl as threatened.
>
> I've done some more work on this and hope to post an updated patchset
> tomorrow. Before that though, is there any objection to going ahead
> with pushing the 0001 patch (pgindent'ing ecpg's lexer and parser
> files)? It's pretty bulky yet of no intellectual interest, so I'd
> like to stop carrying it forward.

The indentation patch looks good to me and it would be good to get it
out of the way.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Banck 2024-08-15 07:20:28 Re: Improve error message for ICU libraries if pkg-config is absent
Previous Message Zhijie Hou (Fujitsu) 2024-08-15 07:18:42 RE: Conflict detection and logging in logical replication