Re: [PATCH] Windows x64 [repost]

On Tue, Jan 5, 2010 at 12:58, Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp> wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
>  > 2009/12/4 Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>:
>  > > Thanks to suggestion.
>  > > I send pathces again by another mailer for the archive.
>  > >
>  > > Sorry to waste resources, below is same content that I send before.
>  >
>  > I have a couple of comments about the first patch (I'll get to the
>  > others later):
>  >
>  > config.win32.h has:
>  > + #ifdef _MSC_VER
>  > + /* #undef HAVE_STDINT_H */
>  > + #else
>  >   #define HAVE_STDINT_H 1
>  > + #endif
>  >
>  > Is that really necessary? config.h.win32 is only used on MSVC builds, no?
>
> I also think it is unnecessary.
>
> But pg_config.h.win32 was referred from "src/bcc32.mak".
> Is Borland C++ still supported?
> It is an unnecessary code if not becoming a problem to Borland.

Hmm. Yeah, that's a good question. I'd say it's supported on 8.4,
because it's in the docs, and I think it works. As for 8.5, it will
only be supported if somebody steps up and does the testing around RC
time.

Having accidentally configured that thing wrong for no change for
libpq (I think it was), I'm not convinced it wil actually break
Borland. So let's leave it this way unless someone confirms it's
broken.

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/