From: | Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [PATCH] Windows x64 [repost] |
Date: | 2010-01-05 11:58:51 |
Message-ID: | 36480.1262692731@srapc2360.sra.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> 2009/12/4 Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>:
> > Thanks to suggestion.
> > I send pathces again by another mailer for the archive.
> >
> > Sorry to waste resources, below is same content that I send before.
>
> I have a couple of comments about the first patch (I'll get to the
> others later):
>
> config.win32.h has:
> + #ifdef _MSC_VER
> + /* #undef HAVE_STDINT_H */
> + #else
> #define HAVE_STDINT_H 1
> + #endif
>
> Is that really necessary? config.h.win32 is only used on MSVC builds, no?
I also think it is unnecessary.
But pg_config.h.win32 was referred from "src/bcc32.mak".
Is Borland C++ still supported?
It is an unnecessary code if not becoming a problem to Borland.
--
Tsutomu Yamada
SRA OSS, Inc. Japan
From | Date | Subject | |
---|---|---|---|
Next Message | Markus Wanner | 2010-01-05 12:08:41 | Re: Testing with concurrent sessions |
Previous Message | Magnus Hagander | 2010-01-05 11:00:42 | Re: [PATCH] Windows x64 [repost] |