Re: Change to config.pl processing in the msvc build environment

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Change to config.pl processing in the msvc build environment
Date: 2010-01-05 13:37:06
Message-ID: 9837222c1001050537o8005a78g94d26f7a1bdbbe9e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Jan 3, 2010 at 05:13, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>
>
> Peter Eisentraut wrote:
>>
>> On fre, 2010-01-01 at 16:32 +0100, Magnus Hagander wrote:
>>
>>>
>>> I therefor propose that we rename this file to "config.pl.default",
>>> and change the scripts to first load config.pl.default, and then load
>>> config.pl if it exists.
>>>
>>
>> I'd keep the naming so that the extension .pl is preserved.  Helps
>> editors and such.
>>
>>
>
> Right ... let's call it "default_config.pl" or some such. Otherwise it looks
> sane enough. I don't think the "parens on trailing conditions" issue is
> anything other than just a matter of taste. I often use them because I've
> occasionally been caught by not doing so.

Ok, I've applied this patch with the name change to config_default.pl
(that way it still sorts next to config.pl etc, which was how Dave
convinced me of the config.pl.default name in the first place :D)

--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2010-01-05 13:40:20 Re: [PATCH] Windows x64 [repost]
Previous Message Pavel Stehule 2010-01-05 13:23:08 Re: quoting psql varible as identifier