Re: Suspicious strcmp() in src/backend/parser/parse_expr.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Rikard Falkeborn <rikard(dot)falkeborn(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: Suspicious strcmp() in src/backend/parser/parse_expr.c
Date: 2019-04-11 14:12:06
Message-ID: 9612.1554991926@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

David Rowley <david(dot)rowley(at)2ndquadrant(dot)com> writes:
> formatting.c in NUM_prepare_locale()

> else if (strcmp(Np->decimal, ",") !=0)

I'll bet a nickel that that's pgindent's fault. It probably thinks
that "decimal" is a typedef (greps typedefs.list ... yes), and that
tends to result in funny space-omissions later in the line.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Christopher Browne 2019-04-11 15:01:55 Re: List of issues with 4.5 that need to be fixed
Previous Message David Rowley 2019-04-11 14:06:11 Re: Suspicious strcmp() in src/backend/parser/parse_expr.c