| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Rikard Falkeborn <rikard(dot)falkeborn(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Suspicious strcmp() in src/backend/parser/parse_expr.c |
| Date: | 2019-04-12 00:58:57 |
| Message-ID: | 20190412005857.GA2144@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Apr 11, 2019 at 10:12:06AM -0400, Tom Lane wrote:
> I'll bet a nickel that that's pgindent's fault. It probably thinks
> that "decimal" is a typedef (greps typedefs.list ... yes), and that
> tends to result in funny space-omissions later in the line.
Yes, I can see as well that pgindent complains here. As that would
result in more noise on follow-up pgindent runs, I am not changing
this one.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-04-12 01:29:54 | Re: Suspicious strcmp() in src/backend/parser/parse_expr.c |
| Previous Message | Alvaro Herrera | 2019-04-11 15:06:36 | Re: List of issues with 4.5 that need to be fixed |