From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | Re: pgsql: Improve wording of some pg_upgrade failure reports. |
Date: | 2021-05-12 22:05:38 |
Message-ID: | 92276bad-c850-4207-4863-96ec60116ee1@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 29.04.21 21:40, Tom Lane wrote:
> Improve wording of some pg_upgrade failure reports.
>
> Don't advocate dropping a whole table when dropping a column would
> serve. While at it, try to make the layout of these messages a
> bit cleaner and more consistent.
I don't understand how this makes the message layout cleaner. For example, this
@@ -456,10 +458,10 @@ old_11_check_for_sql_identifier_data_type_usage(ClusterInfo *cluster)
output_path))
{
pg_log(PG_REPORT, "fatal\n");
- pg_fatal("Your installation contains the \"sql_identifier\" data type in user tables\n"
- "and/or indexes. The on-disk format for this data type has changed, so this\n"
- "cluster cannot currently be upgraded. You can remove the problem tables or\n"
- "change the data type to \"name\" and restart the upgrade.\n"
+ pg_fatal("Your installation contains the \"sql_identifier\" data type in user tables.\n"
+ "The on-disk format for this data type has changed, so this\n"
+ "cluster cannot currently be upgraded. You can\n"
+ "drop the problem columns and restart the upgrade.\n"
"A list of the problem columns is in the file:\n"
" %s\n\n", output_path);
turns a message with uniform line length layout into a message with random line lengths.
What is the rationale behind this?
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-05-12 22:14:06 | Re: pgsql: Improve wording of some pg_upgrade failure reports. |
Previous Message | Tom Lane | 2021-05-12 21:41:31 | pgsql: Doc: update bki.sgml's statements about OID ranges. |