| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Improve wording of some pg_upgrade failure reports. |
| Date: | 2021-05-12 22:14:06 |
| Message-ID: | 1361791.1620857646@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 29.04.21 21:40, Tom Lane wrote:
>> Don't advocate dropping a whole table when dropping a column would
>> serve. While at it, try to make the layout of these messages a
>> bit cleaner and more consistent.
> I don't understand how this makes the message layout cleaner.
The main thing that's cleaner IMO is that it's separated what one
could call the primary error message ("Your installation contains FOO.")
from the errdetail, which formerly was run onto the same line in
some cases, but not others.
For translatability purposes, maybe we could consider how to split
those texts into separate message strings for each sentence? The
detail text is pretty nearly boilerplate and could be unified,
I suspect.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-05-12 22:41:47 | pgsql: Double-space commands in system_constraints.sql/system_functions |
| Previous Message | Peter Eisentraut | 2021-05-12 22:05:38 | Re: pgsql: Improve wording of some pg_upgrade failure reports. |