pgsql: Double-space commands in system_constraints.sql/system_functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Double-space commands in system_constraints.sql/system_functions
Date: 2021-05-12 22:41:47
Message-ID: E1lgxY3-00008Y-PA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Double-space commands in system_constraints.sql/system_functions.sql.

Previously, any error reported by the backend while reading
system_constraints.sql would report the entire file, not just the
particular command it was working on. (Ask me how I know.) Likewise,
there were chunks of system_functions.sql that would be read as one
command, which would be annoying if anything failed there.

The issue for system_constraints.sql is an oversight in commit
dfb75e478. I didn't try to trace down where the poor formatting
in system_functions.sql started, but it's certainly contrary to
the advice at the head of that file.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7dde98728a2ef6d48ef397ee783dd130fdb34e6b

Modified Files
--------------
src/backend/catalog/genbki.pl | 3 +-
src/backend/catalog/system_functions.sql | 47 ++++++++++++++++++++++++++++++++
2 files changed, 49 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2021-05-12 23:19:15 pgsql: Rename the logical replication global "wrconn"
Previous Message Tom Lane 2021-05-12 22:14:06 Re: pgsql: Improve wording of some pg_upgrade failure reports.