pgsql: Improve wording of some pg_upgrade failure reports.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve wording of some pg_upgrade failure reports.
Date: 2021-04-29 19:40:41
Message-ID: E1lcCWf-0008S3-RE@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve wording of some pg_upgrade failure reports.

Don't advocate dropping a whole table when dropping a column would
serve. While at it, try to make the layout of these messages a
bit cleaner and more consistent.

Per suggestion from Daniel Gustafsson. No back-patch, as we generally
don't like to churn translatable messages in released branches.

Discussion: https://postgr.es/m/2798740.1619622555@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c9c37ae03fea0c8ad467392ddf03940b61974935

Modified Files
--------------
src/bin/pg_upgrade/check.c | 10 +++++-----
src/bin/pg_upgrade/version.c | 26 ++++++++++++++------------
2 files changed, 19 insertions(+), 17 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2021-04-30 02:27:25 pgsql: Another try to fix the test case added by commit f5fc2f5b23.
Previous Message Tom Lane 2021-04-29 19:25:00 pgsql: Fix some more omissions in pg_upgrade's tests for non-upgradable