Re: ECPG Refactor: move sqlca variable in ecpg_log()

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: "Yuto Sasaki (Fujitsu)" <sasaki(dot)yuto-00(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: ECPG Refactor: move sqlca variable in ecpg_log()
Date: 2024-10-18 17:43:45
Message-ID: 911868.1729273425@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
> I've attached the latest version of the patch, now including the commit log.
> Unless there are any objections, I'll proceed with committing it.

LGTM. Maybe move down the sqlca variable declaration, so that the
declarations still match the order in which the variables are
initialized? That's just cosmetic of course.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2024-10-18 18:56:08 Inconsistent use of relpages = -1
Previous Message Joel Jacobson 2024-10-18 17:24:34 Re: New "raw" COPY format