| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | "Yuto Sasaki (Fujitsu)" <sasaki(dot)yuto-00(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ECPG Refactor: move sqlca variable in ecpg_log() |
| Date: | 2024-10-18 05:45:41 |
| Message-ID: | 8bda6c8f-a36a-4419-ad8c-4f4f80c1dd95@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/10/16 18:52, Fujii Masao wrote:
>
>
> On 2024/10/16 15:04, Yuto Sasaki (Fujitsu) wrote:
>> >Hmm, I'm not sure we want that, because if we do this, then
>> >ECPGget_sqlca() gets run with the debug_mutex held. In the original
>> >coding, it's run without the mutex.
>>
>> Thank you for pointing that out. I agree with your observation. But there is
>> another room for improvement - we can avoid unnecessary calls to ECPGget_sqlca()
>> by moving just before mutex lock.
>
> +1
>
>> PSA a patch.
>
> The patch looks good to me.
I've attached the latest version of the patch, now including the commit log.
Unless there are any objections, I'll proceed with committing it.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-ecpg-Refactor-ecpg_log-to-skip-unnecessary-calls-.patch | text/plain | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2024-10-18 05:47:37 | Re: Doc: shared_memory_size_in_huge_pages with the "SHOW" command. |
| Previous Message | Andrey M. Borodin | 2024-10-18 05:35:16 | Re: UUID v7 |