| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Yuto Sasaki (Fujitsu)" <sasaki(dot)yuto-00(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ECPG Refactor: move sqlca variable in ecpg_log() |
| Date: | 2024-10-21 14:25:18 |
| Message-ID: | 6ecf2818-386b-41d9-a737-dda47a32f62f@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/10/19 2:43, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> I've attached the latest version of the patch, now including the commit log.
>> Unless there are any objections, I'll proceed with committing it.
>
> LGTM. Maybe move down the sqlca variable declaration, so that the
> declarations still match the order in which the variables are
> initialized? That's just cosmetic of course.
Thanks for the review! I've updated the patch accordingly, i.e.,
moved the declaration of the sqlca variable right after fmt.
The v3 patch is attached.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-ecpg-Refactor-ecpg_log-to-skip-unnecessary-calls-.patch | text/plain | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-10-21 14:35:00 | Re: New "raw" COPY format |
| Previous Message | Ashutosh Bapat | 2024-10-21 14:11:44 | Re: [PATCH] Add array_reverse() function |