| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Yuto Sasaki (Fujitsu)" <sasaki(dot)yuto-00(at)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: ECPG Refactor: move sqlca variable in ecpg_log() |
| Date: | 2024-10-22 15:02:55 |
| Message-ID: | 426af17c-6fc8-4e14-8ae0-e63f46b4c6cc@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2024/10/21 23:25, Fujii Masao wrote:
>
>
> On 2024/10/19 2:43, Tom Lane wrote:
>> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>>> I've attached the latest version of the patch, now including the commit log.
>>> Unless there are any objections, I'll proceed with committing it.
>>
>> LGTM. Maybe move down the sqlca variable declaration, so that the
>> declarations still match the order in which the variables are
>> initialized? That's just cosmetic of course.
>
> Thanks for the review! I've updated the patch accordingly, i.e.,
> moved the declaration of the sqlca variable right after fmt.
> The v3 patch is attached.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2024-10-22 15:09:59 | Re: type cache cleanup improvements |
| Previous Message | Jehan-Guillaume de Rorthais | 2024-10-22 14:54:45 | Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails |