| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-20 15:43:55 |
| Message-ID: | 90aa6653-3cea-42ed-8b62-1cfc9675aad3@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.12.23 12:40, Andres Freund wrote:
> Hm, or perhaps we should just get rid of sed use altogether. The sepgsql case
> is trivially translateable to perl, and postprocess_dtrace.sed isn't
> much harder.
Maybe yeah, but also it seems fine as is and we can easily fix the
present issue ...
> OTOH, I actually don't think it's valid to not have sed when you have
> dtrace. Erroring out in a weird way in such an artificially constructed test
> doesn't really seem like a problem.
Agreed. So let's just make it not-required, and that should work.
Updated patch set attached.
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-meson-Make-sed-optional.patch | text/plain | 1.5 KB |
| v2-0002-meson-Make-gzip-and-tar-optional.patch | text/plain | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Emre Hasegeli | 2023-12-20 15:58:17 | Re: "pgoutput" options missing on documentation |
| Previous Message | Tristan Partin | 2023-12-20 15:39:55 | Re: Unchecked strdup leading to segfault in pg_dump |