Re: "pgoutput" options missing on documentation

From: Emre Hasegeli <emre(at)hasegeli(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: "pgoutput" options missing on documentation
Date: 2023-12-20 15:58:17
Message-ID: CAE2gYzzAjB1Ji6odt4mw1n+fJjV7Y9zrDEjgJkxwpoCoG0an9g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> We don't expect unrecognized option here and for such a thing, we use
> elog in the code. See the similar usage in
> parseCreateReplSlotOptions().

"pgoutput" is useful for a lot of applications other than our logical
replication subscriber. I think we should expect anything and handle
errors nicely.

> I think we should move to 0002 patch now. In that, I suggest preparing
> separate back branch patches.

They are attached.

Attachment Content-Type Size
v13-0001-doc-Clarify-pgoutput-options.patch application/octet-stream 4.0 KB
master-0001-doc-Clarify-pgoutput-options.patch application/octet-stream 8.4 KB
v15-0001-doc-Clarify-pgoutput-options.patch application/octet-stream 6.7 KB
v12-0001-doc-Clarify-pgoutput-options.patch application/octet-stream 4.0 KB
v14-0001-doc-Clarify-pgoutput-options.patch application/octet-stream 5.1 KB
v16-0001-doc-Clarify-pgoutput-options.patch application/octet-stream 8.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2023-12-20 16:02:49 Re: Remove MSVC scripts from the tree
Previous Message Peter Eisentraut 2023-12-20 15:43:55 Re: Remove MSVC scripts from the tree