| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de>, vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove MSVC scripts from the tree |
| Date: | 2023-12-21 09:12:46 |
| Message-ID: | bfd5a0c0-8db5-4ee0-a479-3f0587f0d3c3@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.12.23 16:43, Peter Eisentraut wrote:
> On 20.12.23 12:40, Andres Freund wrote:
>> Hm, or perhaps we should just get rid of sed use altogether. The
>> sepgsql case
>> is trivially translateable to perl, and postprocess_dtrace.sed isn't
>> much harder.
>
> Maybe yeah, but also it seems fine as is and we can easily fix the
> present issue ...
>
>> OTOH, I actually don't think it's valid to not have sed when you have
>> dtrace. Erroring out in a weird way in such an artificially
>> constructed test
>> doesn't really seem like a problem.
>
> Agreed. So let's just make it not-required, and that should work.
>
> Updated patch set attached.
I have committed these two.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-12-21 09:14:35 | Re: ci: Build standalone INSTALL file |
| Previous Message | Egor Chindyaskin | 2023-12-21 08:45:47 | Re: Stack overflow issue |