| From: | "Ivan E(dot) Panchenko" <i(dot)panchenko(at)postgrespro(dot)ru> |
|---|---|
| To: | pgsql-www(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Postgres Pro build for windows |
| Date: | 2017-12-22 10:16:43 |
| Message-ID: | 8f4e42dc-0cb4-40c6-899c-aca5435e0111@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
Hi,
13.12.2017 13:09, Daniel Gustafsson пишет:
>> On 13 Dec 2017, at 11:05, Ivan E. Panchenko <i(dot)panchenko(at)postgrespro(dot)ru> wrote:
>>
>> 13.12.2017 12:26, Daniel Gustafsson пишет:
>>>> On 13 Dec 2017, at 10:12, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>>
>>>> Hi,
>>>>
>>>> I have no objections, however I'm also extremely short of time right now, as I'm only in the office for a couple more days before Christmas and already have a huge backlog. If someone else can pick this up it would be a big help.
>>> The markup in the patch looks fine, there are however two small typos that
>>> should be fixed before pushing:
>>>
>>> +including its old versions, provides automatic server preconfiguraion based
>>>
>>> s/preconfiguraion/preconfiguration/
>>>
>>> +sources are avaiable at github.
>>>
>>> s/avaiable/available/
>>>
>>> Further, since GitHub is a name I think we should capitalize it as they do (ie
>>> GitHub).
>> Daniel, thanks for your corrections. Sorry for the misprints.
>> The improved patch is attached.
> No worries. Updated patch looks good to me.
Can anybody install the patch ?
Happy holidays!
Regards,
Ivan
>
> cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| pgpro-windows.patch | text/x-patch | 1023 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tung Thanh Nguyen | 2017-12-24 07:31:37 | WikiEditing - Editor privileges required! |
| Previous Message | Craig Ringer | 2017-12-22 00:33:37 | Re: The pg_indent on on ftp is outdated |