| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | "Ivan E(dot) Panchenko" <i(dot)panchenko(at)postgrespro(dot)ru> |
| Cc: | pgsql-www(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Postgres Pro build for windows |
| Date: | 2017-12-13 10:09:43 |
| Message-ID: | 10F7799F-20BE-45CE-B684-F6DD1DEDBB24@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
> On 13 Dec 2017, at 11:05, Ivan E. Panchenko <i(dot)panchenko(at)postgrespro(dot)ru> wrote:
>
> 13.12.2017 12:26, Daniel Gustafsson пишет:
>>> On 13 Dec 2017, at 10:12, Dave Page <dpage(at)pgadmin(dot)org> wrote:
>>>
>>> Hi,
>>>
>>> I have no objections, however I'm also extremely short of time right now, as I'm only in the office for a couple more days before Christmas and already have a huge backlog. If someone else can pick this up it would be a big help.
>> The markup in the patch looks fine, there are however two small typos that
>> should be fixed before pushing:
>>
>> +including its old versions, provides automatic server preconfiguraion based
>>
>> s/preconfiguraion/preconfiguration/
>>
>> +sources are avaiable at github.
>>
>> s/avaiable/available/
>>
>> Further, since GitHub is a name I think we should capitalize it as they do (ie
>> GitHub).
> Daniel, thanks for your corrections. Sorry for the misprints.
> The improved patch is attached.
No worries. Updated patch looks good to me.
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2017-12-13 11:11:20 | Ampersands without entities |
| Previous Message | Ivan E. Panchenko | 2017-12-13 10:05:25 | Re: Postgres Pro build for windows |