Re: pgsql: Add support for basic NUMA awareness

Hi,

On April 8, 2025 10:05:48 AM EDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>>> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> wrote:
>>> Add support for basic NUMA awareness
>
>> dogfish is a little bit upset it seems.
>
>Hm, but why isn't anything else?

I assume it's a question of degree of parallelism. I was able to repro the failure when building from a clean tree with unlimited parallelism.

>I noticed this a little further up in dogfish's log:
>
>ninja: bad depfile: expected ':', saw 's'

I noticed that too - but it happened even before the hard failures. Will look at it in a bit.

>> Looking at pg_numa.c, shouldn't the include of postgres.h have an #ifndef
>> FRONTEND guard for postgres_fe.h as well?
>
>No, because it's evidently backend-only code. The real question
>is why is it in src/port/, because everything there gets built
>for both frontend and backend.

I think part of the file would make sense to eventually use in FE code, we should move the SQL function and the page size function out.

Greetings,

Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.