Re: pgsql: Add support for basic NUMA awareness

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: 2025-04-08 14:05:48
Message-ID: 3976705.1744121148@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
>> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> wrote:
>> Add support for basic NUMA awareness

> dogfish is a little bit upset it seems.

Hm, but why isn't anything else?

I noticed this a little further up in dogfish's log:

ninja: bad depfile: expected ':', saw 's'

I wonder if there's something a bit wrong with dogfish's meson
and/or ninja versions.

> Looking at pg_numa.c, shouldn't the include of postgres.h have an #ifndef
> FRONTEND guard for postgres_fe.h as well?

No, because it's evidently backend-only code. The real question
is why is it in src/port/, because everything there gets built
for both frontend and backend.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-04-08 14:24:21 Re: pgsql: Add support for basic NUMA awareness
Previous Message Bruce Momjian 2025-04-08 13:36:47 Re: pgsql: Fix PG 17 [NOT] NULL optimization bug for domains