Re: pgsql: Add support for basic NUMA awareness

> On 7 Apr 2025, at 23:18, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> wrote:
>
> Add support for basic NUMA awareness

dogfish is a little bit upset it seems.

ninja: job failed: ccache gcc -Isrc/port/libpgport.a.p -Isrc/include -I../pgsql/src/include -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O2 -g -fno-strict-aliasing -fwrapv -fexcess-precision=standard -D_GNU_SOURCE -Wmissing-prototypes -Wpointer-arith -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wdeclaration-after-statement -Wmissing-variable-declarations -Wno-format-truncation -Wno-stringop-truncation -fPIC -DFRONTEND -MD -MQ src/port/libpgport.a.p/pg_numa.c.o -MF src/port/libpgport.a.p/pg_numa.c.o.d -o src/port/libpgport.a.p/pg_numa.c.o -c ../pgsql/src/port/pg_numa.c
In file included from ../pgsql/src/include/postgres.h:49,
from ../pgsql/src/port/pg_numa.c:16:
../pgsql/src/include/utils/elog.h:79:10: fatal error: utils/errcodes.h: No such file or directory
79 | #include "utils/errcodes.h"
| ^~~~~~~~~~~~~~~~~~
compilation terminated.

Looking at pg_numa.c, shouldn't the include of postgres.h have an #ifndef
FRONTEND guard for postgres_fe.h as well?

--
Daniel Gustafsson