Re: pgsql: Add support for basic NUMA awareness

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Daniel Gustafsson <daniel(at)yesql(dot)se>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
Subject: Re: pgsql: Add support for basic NUMA awareness
Date: 2025-04-08 14:36:32
Message-ID: 3979923.1744122992@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On April 8, 2025 10:05:48 AM EDT, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I noticed this a little further up in dogfish's log:
>>
>> ninja: bad depfile: expected ':', saw 's'

> I noticed that too - but it happened even before the hard failures. Will look at it in a bit.

After catching up on the hackers thread, I wondered if this isn't
actually part of the identical issue, that is ninja is noticing
that there's not a dependency leading to that include file.

> I think part of the file would make sense to eventually use in FE code, we should move the SQL function and the page size function out.

Works for me. But a file in src/port/ should really use only c.h
if at all possible. Otherwise (as Andrew said) it has to choose
one of postgres.h and postgres_fe.h depending on FRONTEND.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2025-04-08 14:49:37 Re: pgsql: Add support for basic NUMA awareness
Previous Message Andres Freund 2025-04-08 14:24:21 Re: pgsql: Add support for basic NUMA awareness