| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. |
| Date: | 2022-07-18 22:20:44 |
| Message-ID: | 840982.1658182844@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2022-07-18 18:06:22 -0400, Tom Lane wrote:
>> I took it out and fixed the half-dozen places where I got warnings,
>> as attached.
> Grepping for 'no warnings' shows that check_rules.pl has the same
> issue. Perhaps worth fixing at the same time, given how closely related they
> are?
Ah, I didn't think to look around. I'll see what I can do there.
>> Seem like a good fix?
> Looks good to my not-perl-trained eyes.
Yeah, I'm more worried about non-idiomatic usage than whether
it works or not.
> Might be worth making sure the output files are the same before / after? You
> probably already checked...
Yup, I did.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-18 22:36:50 | Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. |
| Previous Message | Andres Freund | 2022-07-18 22:15:35 | Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. |