Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
Date: 2022-07-18 22:36:50
Message-ID: 846745.1658183810@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
>> Grepping for 'no warnings' shows that check_rules.pl has the same
>> issue. Perhaps worth fixing at the same time, given how closely related they
>> are?

> Ah, I didn't think to look around. I'll see what I can do there.

Oh, that one's only hiding *one* sloppy spot. However, while testing
it I realized that the Makefile rule has two serious deficiencies:

* check_rules.pl not listed as a prereq, so nothing happens if you
change it and say "make".

* check_rules.pl should be run first. As-is, if it complains,
preproc.y has already been updated and so another run will succeed.

You might wanna check your meson conversion for the same bugs.

regards, tom lane

Attachment Content-Type Size
fix-poor-perl-style-2.patch text/x-diff 3.7 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2022-07-18 22:53:50 Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.
Previous Message Tom Lane 2022-07-18 22:20:44 Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*.