| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. |
| Date: | 2022-07-18 22:06:22 |
| Message-ID: | 838180.1658181982@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> That'd make some sense - but it doesn't look like perlcritic is digging that
> deep.
Meh, that's the other explanation :-(
> I'll push the obvious fix in a bit.
Cool. While looking at this, I wondered if parse.pl's handy-dandy
little exception
no warnings 'uninitialized';
might be related to the issue. Evidently it's not, but now that
I've noticed it I definitely think it's not up to project standard.
I took it out and fixed the half-dozen places where I got warnings,
as attached. Seem like a good fix?
regards, tom lane
| Attachment | Content-Type | Size |
|---|---|---|
| avoid-uninitialized-variables-in-parse.pl.patch | text/x-diff | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-07-18 22:15:35 | Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. |
| Previous Message | Andres Freund | 2022-07-18 21:55:28 | pgsql: ecpg: use our instead of my in parse.pl to fix perlcritic compla |