From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: ecpg: use our instead of my in parse.pl to fix perlcritic compla |
Date: | 2022-07-18 21:55:28 |
Message-ID: | E1oDYi7-000B0F-Hq@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
ecpg: use our instead of my in parse.pl to fix perlcritic complaint
In db0a272d123 I used open(our $something, ...), which perlcritic doesn't
like. It looks like the warning is due to perlcritic knowing about 'my' but
not 'our' when checking for bareword file handles.
However, it's clearly unnecessary to use "our" here, change it to "my".
Via buildfarm member crake and discussion with Tom Lane.
Discussion: https://postgr.es/m/20220718215042.sl3hivoupdb7lkwv@awork3.anarazel.de
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d268d0f7a16e9e3c6de660b73543d875b8187def
Modified Files
--------------
src/interfaces/ecpg/preproc/parse.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2022-07-18 22:06:22 | Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. |
Previous Message | Andres Freund | 2022-07-18 21:50:42 | Re: pgsql: ecpg: Output dir, source dir, stamp file argument for preproc/*. |