| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Move strtoint() to common |
| Date: | 2018-03-15 22:57:27 |
| Message-ID: | 8299.1521154647@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Oh ... duh. We've been assuming that the strtoint change broke it,
but that's wrong. The test case that is failing is new as of yesterday,
and the correct answer is that it's never worked on Windows. See
I think what's wrong is that src/tools/msvc/ecpg_regression.proj
needs to be taught that tests under ecpg/test/compat-oracle need
to be run with "-C ORACLE". Neither that directory nor that
switch existed before yesterday. There's already stuff in there
that knows about "-C INFORMIX", but beyond seeing the switch it
looks like line noise to me, so I'm not volunteering to fix it.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-15 23:41:32 | Re: pgsql: Add tests for reinit.c |
| Previous Message | Tom Lane | 2018-03-15 22:30:08 | Re: pgsql: Move strtoint() to common |