Re: pgsql: Move strtoint() to common

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Move strtoint() to common
Date: 2018-03-16 09:55:46
Message-ID: 02f2c108-384b-c21c-9fd7-5f6773940d10@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Am 15.03.2018 um 23:57 schrieb Tom Lane:
> Oh ... duh. We've been assuming that the strtoint change broke it,
> but that's wrong. The test case that is failing is new as of yesterday,
> and the correct answer is that it's never worked on Windows. See
> ...

Correct, thanks for figuring this out Tom. The messages were confusing,
it sure looked like a strtoint problem to me. And admittedly I don't
know much about the Windows build.

Also I was not able to spend enough time looking into this as my flight
home from SCaLE took almost exactly 80 hours, among which 24 were
literally on airplanes and another 40 in St. John's, Canada. Yeah, I
hadn't heard of this place before either.

Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message David Steele 2018-03-16 13:36:36 Re: pgsql: Add tests for reinit.c
Previous Message Andrew Dunstan 2018-03-16 03:51:57 Re: pgsql: Move strtoint() to common