| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Move strtoint() to common |
| Date: | 2018-03-15 22:30:08 |
| Message-ID: | 7070.1521153008@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Tom Lane wrote:
>> build now works, ecpg tests fail.
> I stared at the code for a while, didn't notice anything amiss. I'm
> mystified. Peter?
I'm wondering if the Windows environment is somehow supplying a
"strtoint" that isn't actually ABI-compatible with ours.
A different theory is that the pg_restrict markers are bollixing things.
No idea how, but they don't look like they're really doing anything for us
optimization-wise, so it doesn't seem unreasonable to remove them and see
if that makes a difference.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-03-15 22:57:27 | Re: pgsql: Move strtoint() to common |
| Previous Message | Tom Lane | 2018-03-15 21:09:12 | pgsql: Clean up duplicate table and function names in regression tests. |