Re: On disable_cost

From: Alena Rybakina <a(dot)rybakina(at)postgrespro(dot)ru>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: On disable_cost
Date: 2024-10-10 13:02:53
Message-ID: 81a4d749-3c02-44cd-972a-adf3e71199bd@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi!

On 10.10.2024 15:43, David Rowley wrote:
> On Tue, 8 Oct 2024 at 04:14, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
>> I think you have adequate consensus to proceed with this. I'd just ask
>> that you don't disappear completely if it turns out that there are
>> problems. I accept that my commit created this problem and I'm
>> certainly willing to be involved too if we need to sort out more
>> things.
> Thanks. I've attached a polished-up version of the earlier patch.
>
> I spent quite a bit of time testing it by manually adjusting
> disabled_nodes while attached with my debugger. Doing it that way was
> easier as it's often hard and maybe sometimes not possible to get the
> disabled node you want in a plan.
>
> I'll loop back to the documentation part and Laruenz's patch after
> this part is committed.
>
> If anyone wants to take a look at the attached, please do so.
> Otherwise, I'm pretty happy with it and will likely push it on New
> Zealand Friday (aka later today).
>
> David

I think you missed some previous output and we should fix that.

--
Regards,
Alena Rybakina
Postgres Professional

Attachment Content-Type Size
disable_nodes.diff text/x-patch 751 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-10-10 13:10:53 Re: Add contrib/pg_logicalsnapinspect
Previous Message Ranier Vilela 2024-10-10 12:59:59 Re: replace strtok()