Re: Add contrib/pg_logicalsnapinspect

From: Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add contrib/pg_logicalsnapinspect
Date: 2024-10-10 13:10:53
Message-ID: ZwfSXS/3v73388jh@ip-10-97-1-34.eu-west-3.compute.internal
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Thu, Oct 10, 2024 at 12:05:10AM -0700, Masahiko Sawada wrote:
> On Wed, Oct 9, 2024 at 8:32 PM Bertrand Drouvot
> <bertranddrouvot(dot)pg(at)gmail(dot)com> wrote:
> > So I think that having construct_array_builtin()/deconstruct_array_builtin()
> > taking care of XIDOID is the way to go. If that makes sense to you then I'll
> > submit a dedicated patch for it, thoughts?
>
> Your explanation makes sense to me.

Thanks for sharing your thoughts.

> I think it can be included in the main pg_logicalinspect patch as this change
> is a part of it.

Okay, let's keep the discussion here. Please find attached v13 that takes care
of your previous remarks and Peter's one ([1]).

FYI, v13 is splitted into 2 sub-patches (0001 for the discussion related to
XIDOID and construct_array_builtin() and 0002 for the module itself).

FWIW, the elmbyval and elmalign values that are added in 0001 have been deduced
from:

postgres=# select typbyval, typalign from pg_type where typname = 'xid';
typbyval | typalign
----------+----------
t | i
(1 row)

[1]: https://www.postgresql.org/message-id/ZwY5vBI%2BR8Ky7yM5%40ip-10-97-1-34.eu-west-3.compute.internal

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v13-0001-Add-XIDOID-in-de-construct_array_builtin.patch text/x-diff 1.6 KB
v13-0002-Add-contrib-pg_logicalinspect.patch text/x-diff 42.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bertrand Drouvot 2024-10-10 14:42:09 Re: BF mamba failure
Previous Message Alena Rybakina 2024-10-10 13:02:53 Re: On disable_cost