Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY

From: Kevin Grittner <kgrittn(at)ymail(dot)com>
To: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Date: 2015-07-17 14:16:21
Message-ID: 81620362.883169.1437142581761.JavaMail.yahoo@mail.yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> wrote:

> This fixes bug #13126, reported by Kirill Simonov.

It looks like you missed something with the addition of
AT_ReAddComment:

test_ddl_deparse.c:80:11: warning: enumeration value 'AT_ReAddComment' not handled in switch [-Wswitch]
switch (subcmd->subtype)
^

--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2015-07-17 14:40:35 Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY
Previous Message Robert Haas 2015-07-17 13:13:42 pgsql: Add new function pg_notification_queue_usage.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-07-17 14:30:36 Re: [PATCH] Generalized JSON output functions
Previous Message Andrew Dunstan 2015-07-17 14:11:40 Re: [PATCH] Generalized JSON output functions