| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "pgsql-committers(at)postgresql(dot)org" <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY |
| Date: | 2015-07-17 14:40:35 |
| Message-ID: | CAB7nPqTnAyTwrnXfyJdmovu0B991KK3tymgW5NNtPWyU=fhNzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Jul 17, 2015 at 11:16 PM, Kevin Grittner <kgrittn(at)ymail(dot)com> wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> wrote:
>
>> This fixes bug #13126, reported by Kirill Simonov.
>
> It looks like you missed something with the addition of
> AT_ReAddComment:
>
> test_ddl_deparse.c:80:11: warning: enumeration value 'AT_ReAddComment' not handled in switch [-Wswitch]
> switch (subcmd->subtype)
> ^
Oops. If someone could pick up the attached (backpatch to 9.5 needed)...
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150717_testddl_warning.patch | binary/octet-stream | 558 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-07-17 18:10:57 | pgsql: Fix entirely broken permissions test in new alter_operator regre |
| Previous Message | Kevin Grittner | 2015-07-17 14:16:21 | Re: pgsql: Retain comments on indexes and constraints at ALTER TABLE ... TY |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Shulgin, Oleksandr | 2015-07-17 14:40:39 | Re: [PATCH] Generalized JSON output functions |
| Previous Message | Tom Lane | 2015-07-17 14:37:44 | Re: segfault in 9.5alpha - plpgsql function, implicit cast and IMMUTABLE cast function |