| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup. |
| Date: | 2021-11-06 16:10:27 |
| Message-ID: | 77ac2e24-051b-d57a-b02e-4dbc3306f895@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 11/6/21 15:30, Tom Lane wrote:
> Peter Geoghegan <pg(at)bowt(dot)ie> writes:
>> On Fri, Nov 5, 2021 at 7:30 AM Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>>> Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
>
>> I'm seeing a pretty straightforward looking compiler warning following
>> this commit:
>> bbstreamer_file.c:564:24: warning: unused variable ‘mystreamer’
>
> And apparently, that file isn't getting built at all on the MSVC side:
>
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2003%3A52%3A19
>
I got annoyed by the warning so I marked the variable as assert-only.
Haven't done anything about the MSVC issue.
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-11-06 16:13:00 | pgsql: Un-break pg_basebackup's MSVC build. |
| Previous Message | Tomas Vondra | 2021-11-06 16:07:00 | pgsql: Add bool GiST opclass to btree_gist |