Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Cc: Peter Geoghegan <pg(at)bowt(dot)ie>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
Date: 2021-11-06 16:17:35
Message-ID: 515458.1636215455@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> writes:
> I got annoyed by the warning so I marked the variable as assert-only.

Thanks!

> Haven't done anything about the MSVC issue.

I pushed a quick-hack fix for it. Given the ongoing meson work,
I'm not inclined to put in a lot of effort there (like teaching
the MSVC stuff about BBOBJS).

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2021-11-06 16:43:48 pgsql: Second attempt to silence SSL compile failures on hamerkop.
Previous Message Alexander Korotkov 2021-11-06 16:14:21 pgsql: Reset lastOverflowedXid on standby when needed