Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Introduce 'bbstreamer' abstraction to modularize pg_basebackup.
Date: 2021-11-06 14:30:19
Message-ID: 508673.1636209019@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Peter Geoghegan <pg(at)bowt(dot)ie> writes:
> On Fri, Nov 5, 2021 at 7:30 AM Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>> Introduce 'bbstreamer' abstraction to modularize pg_basebackup.

> I'm seeing a pretty straightforward looking compiler warning following
> this commit:
> bbstreamer_file.c:564:24: warning: unused variable ‘mystreamer’

And apparently, that file isn't getting built at all on the MSVC side:

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=bowerbird&dt=2021-11-06%2003%3A52%3A19

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2021-11-06 15:33:37 pgsql: Mark mystreamer variable as PG_USED_FOR_ASSERTS_ONLY
Previous Message Peter Geoghegan 2021-11-06 06:39:05 pgsql: Update obsolete reference in vacuumlazy.c.