| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: --single-transaction hack to pg_upgrade does not work |
| Date: | 2012-12-01 19:31:03 |
| Message-ID: | 7683.1354390263@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2012-12-01 12:14:37 -0500, Tom Lane wrote:
>> It could do with some comments ;-)
> Hehe, yes. Hopefully this version has enough of that.
Hm, maybe too many --- I don't really think it's necessary for utility.c
to provide a redundant explanation of what's happening.
Committed with adjustments --- mainly, the
TransactionIdIsCurrentTransactionId test was flat out wrong, because it
would accept a parent transaction ID as well as a subcommitted
subtransaction ID. We could safely allow the latter, but I don't think
it's worth the trouble to add another xact.c test function.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2012-12-01 19:34:46 | Re: --single-transaction hack to pg_upgrade does not work |
| Previous Message | Tom Lane | 2012-12-01 19:13:29 | Re: --single-transaction hack to pg_upgrade does not work |