| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Little cleanup of ShmemInit function names |
| Date: | 2024-08-28 18:41:22 |
| Message-ID: | 6f27f983-da13-48e5-84c6-516a00c4922e@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/28/24 7:26 PM, Heikki Linnakangas wrote:
> Hmm, I don't see the issue. It's an uncommon sentence structure, but it
> was there before this patch, and it's correct AFAICS. If you grep for
> "which see ", you'll find some more examples of that.
Not sure if it is correct or not but from some googling it seems to be a
direct translation of "quod vide". I think "for which, see" would likely
be more proper English but it is not my native language and we use
"which see" elsewhere so we might as well be consistent and use "which see".
>> On the topic of minor language issues I think the comma below is
>> redundant.
>>
>> "In the normal postmaster case, the shared hash tables are created here."
>
> On second thoughts, I rearranged the sentences in the paragraph a
> little, see attached.
Looks good!
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-08-28 18:44:36 | Re: Little cleanup of ShmemInit function names |
| Previous Message | Tomas Vondra | 2024-08-28 18:01:59 | Re: PATCH: Add hooks for pg_total_relation_size and pg_indexes_size |