| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Andreas Karlsson <andreas(at)proxel(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Little cleanup of ShmemInit function names |
| Date: | 2024-08-28 18:44:36 |
| Message-ID: | 3463157.1724870676@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> On 28/08/2024 18:26, Andreas Karlsson wrote:
>> Small typo with the extra "which" which makes the sentence not flow
>> correctly
>> "This is called from CreateSharedMemoryAndSemaphores(), which see for
>> more comments."
> Hmm, I don't see the issue. It's an uncommon sentence structure, but it
> was there before this patch, and it's correct AFAICS. If you grep for
> "which see ", you'll find some more examples of that.
I didn't check the git history for this particular line, but at least
some of those examples are mine. I'm pretty certain it's good English.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2024-08-28 18:50:31 | Re: On non-Windows, hard depend on uselocale(3) |
| Previous Message | Andreas Karlsson | 2024-08-28 18:41:22 | Re: Little cleanup of ShmemInit function names |