From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Dimitri Fontaine <dfontaine(at)hi-media(dot)com> |
Cc: | Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi>, Josh Berkus <josh(at)agliodbs(dot)com>, pgsql-hackers(at)postgresql(dot)org, David Fetter <david(at)fetter(dot)org> |
Subject: | Re: damage control mode |
Date: | 2010-02-07 21:34:26 |
Message-ID: | 603c8f071002071334k45801541ja3575349b0c2df69@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Feb 7, 2010 at 4:03 PM, Dimitri Fontaine <dfontaine(at)hi-media(dot)com> wrote:
> Marko Tiikkaja <marko(dot)tiikkaja(at)cs(dot)helsinki(dot)fi> writes:
>> The documentation has definitely improved from the last time Robert
>> looked at it, but I fear it still needs some more work. I'm willing to
>> do that work, but I need something concrete.
>
> It seems to me documentation is required to get into the source tree
> before beta, and as we see with some other patches it's definitely the
> case even with our newer procedures that some code gets in without its
> documentation properly finished. I guess this amounts to the commiter
> willing to fill up the docs later on.
>
> But here it's even better as we have the author willing to stay there
> and write needed documentation as soon as community agrees on what that
> is.
>
> In case I'm not clear, what I'm saying is that I think we can consider
> the writable CTE patch ready for commit even though we still have to
> decide what its impacts on documentation should be.
Whether a patch is ready to commit will be up to the committer, and I
am doubtful that anyone other than Tom is qualified to do this one.
Others may feel differently, of course. The rest of us should focus
our effort on improving the patch, rather than arguing about whether
we would commit it as is.
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Dimitri Fontaine | 2010-02-07 21:54:54 | Re: damage control mode |
Previous Message | David E. Wheeler | 2010-02-07 21:25:38 | Re: Hot standby documentation |