From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com> |
Subject: | Re: machine-readable explain output |
Date: | 2009-06-14 17:04:22 |
Message-ID: | 603c8f070906141004l39a08b73j942496136df47268@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jun 14, 2009 at 1:02 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Sun, Jun 14, 2009 at 11:28 AM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> However, using BuildTupleFromCStrings is wasteful/stupid for *both*
>>> text and xml output, so it seems like getting rid of it is the thing
>>> to do here.
>
>> Makes sense. However, if we just make that change in do_tup_output(),
>> then we'll break the ability to use that function for non-text
>> datatypes.
>
> I'd envision it taking Datums, so it doesn't really matter. However,
> as you say, specializing it to text only wouldn't be much of a loss.
I like the Datum option, so I'll work up a patch for that, unless you
want to just do it and spare me the trouble. :-)
...Robert
From | Date | Subject | |
---|---|---|---|
Next Message | Erik Rijkers | 2009-06-14 20:31:48 | 8.4 release notes "Recursive Joins" |
Previous Message | Tom Lane | 2009-06-14 17:02:51 | Re: machine-readable explain output |