From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bernd Helmle <mailings(at)oopsware(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>, Josh Berkus <josh(at)agliodbs(dot)com> |
Subject: | Re: machine-readable explain output |
Date: | 2009-06-15 01:11:41 |
Message-ID: | 603c8f070906141811m690e1a63yf9ac4ee75996b3cb@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Jun 14, 2009 at 1:04 PM, Robert Haas<robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Jun 14, 2009 at 1:02 PM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> On Sun, Jun 14, 2009 at 11:28 AM, Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>>> However, using BuildTupleFromCStrings is wasteful/stupid for *both*
>>>> text and xml output, so it seems like getting rid of it is the thing
>>>> to do here.
>>
>>> Makes sense. However, if we just make that change in do_tup_output(),
>>> then we'll break the ability to use that function for non-text
>>> datatypes.
>>
>> I'd envision it taking Datums, so it doesn't really matter. However,
>> as you say, specializing it to text only wouldn't be much of a loss.
>
> I like the Datum option, so I'll work up a patch for that, unless you
> want to just do it and spare me the trouble. :-)
Here's an attempt. Is this anything like what you had in mind?
...Robert
Attachment | Content-Type | Size |
---|---|---|
do_tup_output_datum-v1.patch | text/x-diff | 6.1 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jacky Leng | 2009-06-15 08:41:42 | Should mdxxx functions(e.g. mdread, mdwrite, mdsync etc) PANIC instead of ERROR when I/O failed? |
Previous Message | David Fetter | 2009-06-14 22:24:19 | Re: [GENERAL] Using results from DELETE ... RETURNING |