Re: [rfc,patch] PL/Proxy in core

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marko Kreen" <markokr(at)gmail(dot)com>
Cc: josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [rfc,patch] PL/Proxy in core
Date: 2008-05-15 16:01:36
Message-ID: 5916.1210867296@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Marko Kreen" <markokr(at)gmail(dot)com> writes:
> On 5/15/08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
>>> Eg. how does src/backend/parser/gram.c not leak memory on syntax error?
>>
>> It's not a leak because the memory can be re-used during the next
>> command.

> I may be blind, but I don't see any static variables there.

Sorry, I was confusing bison with flex --- there are static variables
pointing at buffers within a flex scanner.

For bison it looks like defining YYSTACK_ALLOC/YYSTACK_FREE as
palloc/pfree might be a sane thing to do, but I haven't tested it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2008-05-15 16:09:31 Re: libpq object hooks
Previous Message Merlin Moncure 2008-05-15 15:52:21 Re: libpq object hooks