Re: [rfc,patch] PL/Proxy in core

From: "Marko Kreen" <markokr(at)gmail(dot)com>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: josh(at)agliodbs(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [rfc,patch] PL/Proxy in core
Date: 2008-05-15 15:33:29
Message-ID: e51f66da0805150833h43a5925cw4ec9b3665ae24b61@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/15/08, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > Eg. how does src/backend/parser/gram.c not leak memory on syntax error?
>
> It's not a leak because the memory can be re-used during the next
> command.

I may be blind, but I don't see any static variables there.

> I believe you'll find that trying to make it use palloc is a failure
> because it keeps static pointers that it expects will stay valid across
> calls.

Thats true, I need to drop the redefines if the allocations may be reused.

--
marko

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message pgsql 2008-05-15 15:34:08 Re: SSL and USER_CERT_FILE round 2
Previous Message Tom Lane 2008-05-15 15:06:28 Re: [rfc,patch] PL/Proxy in core