From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | "Merlin Moncure" <mmoncure(at)gmail(dot)com> |
Cc: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Alvaro Herrera" <alvherre(at)commandprompt(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, "Andrew Chernow" <ac(at)esilo(dot)com> |
Subject: | Re: libpq object hooks |
Date: | 2008-05-15 16:09:31 |
Message-ID: | 6044.1210867771@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
"Merlin Moncure" <mmoncure(at)gmail(dot)com> writes:
> The problem is the functions PQhookData(conn, hookname) and
> PQresultHookData(result, hookName). We need these to work in
> functions that are not callbacks. If we eliminate hookname
> completely, there is no way for libpq to know which private state we
> are asking for.
Well, depending on a hook name for this is broken-by-design anyway,
because there is no way for two independently written libraries to
be sure they don't choose conflicting hook names. So the need for
a hook name has to go away.
It might work to use the address of the hook callback function as
a key for retrieving the associated void * pointer. You'd need to
not register the same callback function more than once per object,
but from what I gather here you don't need to.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2008-05-15 17:40:30 | Re: SSL and USER_CERT_FILE round 2 |
Previous Message | Tom Lane | 2008-05-15 16:01:36 | Re: [rfc,patch] PL/Proxy in core |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2008-05-15 16:12:36 | Re: Patch to change psql default banner v6 |
Previous Message | Alvaro Herrera | 2008-05-15 16:09:25 | Re: Patch to change psql default banner v6 |