| From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Description of ForeignPath |
| Date: | 2016-04-20 07:37:06 |
| Message-ID: | 571731A2.7080701@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Fujita-san,
On 2016/04/20 16:20, Etsuro Fujita wrote:
> On 2016/04/18 17:31, Amit Langote wrote:
>> Is the following description now outdated:
>>
>> "ForeignPath represents a potential scan of a foreign table"
>>
>> Considering that there now exists FdwRoutine.GetForeignJoinPaths() whose
>> product is nothing else but a ForeignPath, should it now say (patch
>> attached):
>>
>> "ForeignPath represents a potential scan of foreign table(s)"
>>
>> Or something better.
>
> I think it'd be better to match the comment with that for
> create_foreignscan_path(). So how about "ForeignPath represents a
> potential scan of a foreign table, foreign join, or foreign upper-relation
> processing"? I think we would probably need to update the comment in
> src/backend/optimizer/README (L358), too.
That's a lot better. Updated patch attached.
Thanks,
Amit
| Attachment | Content-Type | Size |
|---|---|---|
| foreignpath-desc-2.patch | text/x-diff | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-04-20 07:53:35 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| Previous Message | Etsuro Fujita | 2016-04-20 07:20:43 | Re: Description of ForeignPath |