| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Description of ForeignPath |
| Date: | 2016-04-21 17:32:11 |
| Message-ID: | CA+TgmoYLLQasjb6ecHetBSXQEHPUHoqnqN1ZA6rNPZ7WkbOLjA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 20, 2016 at 3:37 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> I think it'd be better to match the comment with that for
>> create_foreignscan_path(). So how about "ForeignPath represents a
>> potential scan of a foreign table, foreign join, or foreign upper-relation
>> processing"? I think we would probably need to update the comment in
>> src/backend/optimizer/README (L358), too.
>
> That's a lot better. Updated patch attached.
Looks OK to me, too. Committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-04-21 17:33:23 | Re: Fix of doc for synchronous_standby_names. |
| Previous Message | Robert Haas | 2016-04-21 17:29:15 | Re: [COMMITTERS] pgsql: Move each SLRU's lwlocks to a separate tranche. |